Skip to content

Fix Not here flash, Display name hover and whisper disappearing after a reaction - #103868

Merged
arosiclair merged 4 commits into
Expensify:mainfrom
allgandalf:display-name-not-here-flash
Oct 14, 2026
Merged

arosiclair merged 4 commits into
Expensify:mainfrom
allgandalf:display-name-not-here-flash

Conversation

@allgandalf

@allgandalf allgandalf commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Saving a member's display name sets the name right away, and the page blocks itself for any member who already has one, so Not here showed for a moment while the page was closing. The page now skips that check once it has saved.

The Display name row on Profile was padded 20px on both sides, so its hover stopped short of the edges. It now covers the full width like See chat history.

After a reaction the backend sends the display name whisper back with an empty message, so it was treated as deleted and hidden until the chat was reopened. It is now skipped in isDeletedAction, since its text comes from originalMessage.

Fixed Issues

$ #103853
$ #103856
$ #103933
PROPOSAL:

Tests

  1. Go to workspace settings > Members and invite a new user
  2. Click the invited member, then Profile
  3. Hover over Display name and verify the hover covers the full width, same as See chat history
  4. Click Display name, enter a first and last name and click Save
  5. Verify the page closes without showing Not here
  6. Click the browser's Forward button and verify the Display name page shows Not here
  7. Sign in as the invited member and open their workspace chat
  8. React to the "updated your display name" message and verify it stays visible
  • Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Not here page, before

before.mp4

Not here page, after

after.mp4

Display name hover, before

Display name hover before

Display name hover, after

Display name hover after

Reacting to the display name message, before

react-before.mp4

Reacting to the display name message, after

react-after.mp4

@allgandalf
allgandalf requested review from a team as code owners October 13, 2026 12:06
@melvin-bot
melvin-bot Bot requested review from gijoe0295 and trjExpensify and removed request for a team October 13, 2026 12:06
@melvin-bot

melvin-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T12:18:47.615239Z dea0e3e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@allgandalf

Copy link
Copy Markdown
Contributor Author

jest failure is flaky i think lets rerun

@gijoe0295

Copy link
Copy Markdown
Contributor

Will review in 2 hours

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/ReportActionsUtils.ts 83.77% <100.00%> (-0.75%) ⬇️
src/pages/ProfilePage.tsx 88.18% <ø> (ø)
...rkspace/members/WorkspaceMemberDisplayNamePage.tsx 0.00% <0.00%> (ø)
... and 292 files with indirect coverage changes

@allgandalf allgandalf changed the title Fix Not here page flashing after saving a member's display name Fix Not here page flash and Display name hover on a member's profile Oct 13, 2026
@gijoe0295

gijoe0295 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
  • Not here flash, Display name hover:
Screen.Recording.2026-10-13.at.23.50.18.mov
  • Whisper disappearing after a reaction:
Screen.Recording.2026-10-14.at.11.45.31.mov
Android: mWeb Chrome - Not here flash, Display name hover:
Screen.Recording.2026-10-13.at.23.26.30.mov
  • Whisper disappearing after a reaction:
Screen.Recording.2026-10-14.at.11.48.24.mov
iOS: HybridApp
  • Not here flash, Display name hover:
Screen.Recording.2026-10-14.at.00.10.19.mov
  • Whisper disappearing after a reaction:
Screen.Recording.2026-10-14.at.11.41.10.mov
iOS: mWeb Safari - Not here flash, Display name hover:
Screen.Recording.2026-10-13.at.23.24.39.mov
  • Whisper disappearing after a reaction:
Screen.Recording.2026-10-14.at.11.49.50.mov
MacOS: Chrome / Safari
  • Not here flash, Display name hover:
Screen.Recording.2026-10-13.at.23.03.01.mov
  • Whisper disappearing after a reaction
Screen.Recording.2026-10-14.at.11.50.22.mov

@gijoe0295

Copy link
Copy Markdown
Contributor

@MelvinBot review the changes for accessibility issues and addressed its findings

@MelvinBot

Copy link
Copy Markdown
Contributor

Accessibility review

I found no accessibility issues in this PR, so there is nothing to change.

  • Display name row (ProfilePage.tsx:296-304): Only spacing changed. The press target, hover, and focus highlight now span the full row, which gives a larger target and matches See chat history. The text still lines up with the Email and Pronouns rows.
  • Role and focus: When a name is already set, interactive={false} removes the button role and takes the row out of the tab order (MenuItem.tsx:824-829). Screen readers still read it as "Display name, <name>".
  • Save flow (WorkspaceMemberDisplayNamePage.tsx:58): Screen readers no longer briefly announce the Not here page after Save. This is an improvement. Opening the page again by Forward or a deep link still shows Not here.
What I checked
  • Accessible names: the row label comes from description + title (MenuItem.tsx:580). The PR doesn't change it.
  • Focus indicator: MenuItem shows focus as a background color, not an outline (MenuItem.tsx:811-815). The mhn5 negative margin cancels the 20px padding on avatarSectionWrapper, so the edges don't clip the focus state.
  • Form inputs: labels and aria-labels are unchanged.

This was a code review only. I did not run a screen reader.


view run

@gijoe0295 gijoe0295 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gijoe0295

Copy link
Copy Markdown
Contributor

@arosiclair all yours

trjExpensify
trjExpensify previously approved these changes Oct 13, 2026

@trjExpensify trjExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@allgandalf allgandalf changed the title Fix Not here page flash and Display name hover on a member's profile Fix Not here flash, Display name hover and whisper disappearing after a reaction Oct 14, 2026
@allgandalf

allgandalf commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

@gijoe0295 fixed another issue #103933 can you test

@gijoe0295

gijoe0295 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

@allgandalf all tests passed. Videos updated

@arosiclair
arosiclair merged commit 269dfda into Expensify:main Oct 14, 2026
37 of 38 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.10-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR only fixes three bugs in the member Display name flow: the Not here flash after saving, the hover width on the Display name row, and the display name message disappearing after a reaction. None of these fixes adds a feature or makes any help article sentence wrong.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.5.12-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update is needed. This PR only fixes three bugs in the member Display name flow: the Not here flash after saving, the hover width on the Display name row, and the display name message disappearing after a reaction. None of these fixes adds a feature or makes any help article sentence wrong.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.12-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants